Reviewers: Christian Plesner Hansen, Description: Fix bug 499 by splitting up long-running test to minimise the amount of code that can't be tested on slow targets.
Please review this at http://codereview.chromium.org/385133 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/mjsunit/cyrillic.js M test/mjsunit/mjsunit.status A test/mjsunit/unicode-case-overoptimization.js Index: test/mjsunit/unicode-case-overoptimization.js =================================================================== --- test/mjsunit/unicode-case-overoptimization.js (revision 0) +++ test/mjsunit/unicode-case-overoptimization.js (revision 0) @@ -0,0 +1,35 @@ +// Copyright 2009 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Test all non-ASCII characters individually to ensure that our optimizations +// didn't break anything. +for (var i = 0x80; i <= 0xfffe; i++) { + var c = String.fromCharCode(i); + var c2 = String.fromCharCode(i + 1); + var re = new RegExp("[" + c + "-" + c2 + "]", "i"); + assertTrue(re.test(c), i); +} Index: test/mjsunit/mjsunit.status =================================================================== --- test/mjsunit/mjsunit.status (revision 3302) +++ test/mjsunit/mjsunit.status (working copy) @@ -42,9 +42,10 @@ # Issue 488: this test sometimes times out. array-constructor: PASS || TIMEOUT -# Issue 499 -cyrillic: PASS, TIMEOUT if ($arch == arm) +# Very slow on ARM, contains no architecture dependent code. +unicode-case-overoptimization: PASS, TIMEOUT if ($arch == arm) + [ $arch == arm ] # Slow tests which times out in debug mode. Index: test/mjsunit/cyrillic.js =================================================================== --- test/mjsunit/cyrillic.js (revision 3302) +++ test/mjsunit/cyrillic.js (working copy) @@ -174,15 +174,6 @@ } -// Test all non-ASCII characters individually to ensure that our optimizations -// didn't break anything. -for (var i = 0x80; i <= 0xfffe; i++) { - var c = String.fromCharCode(i); - var c2 = String.fromCharCode(i + 1); - var re = new RegExp("[" + c + "-" + c2 + "]", "i"); - assertTrue(re.test(c), 57); -} - for (var add_non_ascii_character_to_subject = 0; add_non_ascii_character_to_subject < 2; add_non_ascii_character_to_subject++) { --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
