Non-generator non-turbofan parts lgtm. Comments. And can we have test cases
with
nested try-catch pretty please? :)
https://codereview.chromium.org/1010883002/diff/40001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/1010883002/diff/40001/src/objects-inl.h#newcode767
src/objects-inl.h:767: // a handler table array.
Maybe we want to introduce a special fixed array map? Then again that
would just be for debugging and assertions.
https://codereview.chromium.org/1010883002/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1010883002/diff/40001/src/objects.cc#newcode8540
src/objects.cc:8540: for (int i = 0; i < length(); i += kRangeEntrySize)
{
The handler table should be sorted by start_offset (which we could also
assert). We could end the loop early if start_offset > pc_offset, right?
https://codereview.chromium.org/1010883002/diff/40001/src/objects.cc#newcode8547
src/objects.cc:8547: if (start_offset < innermost_start) continue;
This assumes that for nested try-catch, the start_offset of the inner
try-catch is always larger than the start_offset of the outer one. Is
this guaranteed for all platforms?
https://codereview.chromium.org/1010883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
