https://codereview.chromium.org/1024823002/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1024823002/diff/20001/src/heap/mark-compact.cc#newcode648
src/heap/mark-compact.cc:648: static const int
kMaxMaxEvacuationCandidates = 10000;
On 2015/03/20 10:56:53, ulan wrote:
Does this help? I think 1000 pages (1GB) should be enough.

That rather depends on the total heap size.  Not everyone runs with the
limits that Chromium has.  It won't normally make a difference without
--always-compact though.

https://codereview.chromium.org/1024823002/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/1024823002/diff/20001/src/hydrogen.cc#newcode3359
src/hydrogen.cc:3359: function_state_ = &initial_function_state_;
On 2015/03/20 10:56:54, ulan wrote:
Nit: this probably belongs to another CL, but I am fine with landing
it here.

git cl won't let me omit this change for some reason

https://codereview.chromium.org/1024823002/diff/20001/test/mjsunit/regress/regress-3976.js
File test/mjsunit/regress/regress-3976.js (right):

https://codereview.chromium.org/1024823002/diff/20001/test/mjsunit/regress/regress-3976.js#newcode28
test/mjsunit/regress/regress-3976.js:28: table = [];
On 2015/03/20 10:56:54, ulan wrote:
Can we get faster test by setting max_old_space_size to lower value
and
decreasing 1000000 below?

Good idea.  Reducing by a factor of 20 with a max old space size of 50.
That seems to work on both 32 and 64 bit, and it fails without the
&&->|| change.

https://codereview.chromium.org/1024823002/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to