https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.cc#newcode160
src/heap/gc-idle-time-handler.cc:160: last_mark_compact_time +
kMinMillisecondsInBetweenMarkCompact;
On 2015/03/20 12:41:52, jochen (slow) wrote:
you're adding seconds + milliseconds here as far as I can tell
yeah, found it when I run the experiment. already removed.
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.cc#newcode213
src/heap/gc-idle-time-handler.cc:213: printf("start idle round, contexts
disposed\n");
On 2015/03/20 12:41:52, jochen (slow) wrote:
debug code?
Done.
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (right):
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.h#newcode141
src/heap/gc-idle-time-handler.h:141: static const double
kMinMillisecondsInBetweenMarkCompact;
On 2015/03/20 12:41:52, jochen (slow) wrote:
MinTime...InMs would be more consistent with the other constants
Done.
https://codereview.chromium.org/1023153002/diff/1/src/heap/gc-idle-time-handler.h#newcode194
src/heap/gc-idle-time-handler.h:194: double last_mark_comact_time,
On 2015/03/20 12:41:52, jochen (slow) wrote:
idle_time_in_ms is a size_t value. Can last_mark_com*p*act_time be a
size_t as
well? And what's the time unit?
Done.
https://codereview.chromium.org/1023153002/diff/80001/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):
https://codereview.chromium.org/1023153002/diff/80001/test/cctest/test-api.cc#oldcode15745
test/cctest/test-api.cc:15745: // Test that idle notification can be
handled and eventually collects garbage.
These test (both identical) don't provide any value anymore. From the
API, just idle times of 1000ms are interesting. The rest is handled in
the idle handler unit tests.
https://codereview.chromium.org/1023153002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
