Reviewers: Mads Ager, fschneider,

Message:
Quick fix of missing stack check.
Seems to work, but I'll run more tests tomorrow too.


http://codereview.chromium.org/435020/diff/1/6
File src/heap.h (right):

http://codereview.chromium.org/435020/diff/1/6#newcode914
src/heap.h:914: (1 << MapWord::kMapPageIndexBits) * Page::kPageSize;
By popular demand: Make it obvious what map space is restricted by.

http://codereview.chromium.org/435020/diff/1/10
File src/x64/fast-codegen-x64.cc (right):

http://codereview.chromium.org/435020/diff/1/10#newcode392
src/x64/fast-codegen-x64.cc:392:
ASSERT(!Heap::InNewSpace(*Factory::the_hole_value()));
I can't see how we could have been hitting this at all.

Description:
Fast-compiler: Add stack limit checks to back edges of while, do-while and  
for.
A few other tweaks.

Please review this at http://codereview.chromium.org/435020

Affected files:
   M src/arm/fast-codegen-arm.cc
   M src/arm/macro-assembler-arm.h
   M src/arm/macro-assembler-arm.cc
   M src/fast-codegen.cc
   M src/heap.h
   M src/ia32/fast-codegen-ia32.cc
   M src/ia32/macro-assembler-ia32.h
   M src/ia32/macro-assembler-ia32.cc
   M src/x64/fast-codegen-x64.cc
   M src/x64/macro-assembler-x64.h
   M src/x64/macro-assembler-x64.cc



--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to