https://codereview.chromium.org/998253006/diff/60001/include/v8-util.h
File include/v8-util.h (right):
https://codereview.chromium.org/998253006/diff/60001/include/v8-util.h#newcode328
include/v8-util.h:328: p.Reset();
Why do we have to create a Global, then immediately reset it?
https://codereview.chromium.org/998253006/diff/60001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/998253006/diff/60001/include/v8.h#newcode506
include/v8.h:506: // Setting this to nullptr is unecessary and means
there will be no second
Comment is a bit confusing. How about:
The default is nullptr, which means there will be no second pass.
Also, since this is part of V8's official API I think a bit more
explanation is in order. As I understand it, this structure is passed
to the first callback, and the embedder can arrange for a second
callback. When is the second callback called?
https://codereview.chromium.org/998253006/diff/60001/src/global-handles.cc
File src/global-handles.cc (right):
https://codereview.chromium.org/998253006/diff/60001/src/global-handles.cc#newcode288
src/global-handles.cc:288: *location() = reinterpret_cast<Object*>(0x1);
I would prefer some zap value that you can grep for when you find it in
the debugger. How about something phantom-themed:
0x6057ca11 // Gost-call
https://codereview.chromium.org/998253006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
