On 2015/03/30 11:07:15, Hannes Payer wrote:
https://codereview.chromium.org/1034403002/diff/1/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/1034403002/diff/1/src/heap/gc-idle-time-handler.cc#newcode136
src/heap/gc-idle-time-handler.cc:136: kMaxScheduledIdleTime * 2;
On 2015/03/27 15:07:50, rmcilroy wrote:
> Pull out 'kMaxScheduledIdleTime * 2' as a variable named something like
> estimated_time_till_next_idle_notification or similar and add a comment
you
are
> estimating that it will be 2 * frame time since we might miss an idle
period
(or
> whatever your reasoning for this is).
Done.
lgtm, thanks!
https://codereview.chromium.org/1034403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
