Reviewers: titzer,

Message:
On 2015/04/20 13:33:53, titzer wrote:
Looks good, just one more slice.


https://codereview.chromium.org/1094063002/diff/100001/src/compiler/register-allocator.h
File src/compiler/register-allocator.h (right):


https://codereview.chromium.org/1094063002/diff/100001/src/compiler/register-allocator.h#newcode533
src/compiler/register-allocator.h:533: const RegisterConfiguration* const
config_;
Can we split the output of the LiveRangeBuilder into a separate data-only
class
(hopefully struct!) so that we can pass that around?

done.

a struct? are you kidding?

Description:
[turbofan] split register allocator into little pieces

R=tit...@chromium.org

BUG=

Please review this at https://codereview.chromium.org/1094063002/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+1199, -1051 lines):
  M src/compiler/graph-visualizer.h
  M src/compiler/graph-visualizer.cc
  M src/compiler/pipeline.cc
  M src/compiler/register-allocator.h
  M src/compiler/register-allocator.cc


--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to