Comment #2 on issue 4053 by [email protected]: setters-on-elements test bug.
https://code.google.com/p/v8/issues/detail?id=4053

The flow is..

deopt "foo" -> Repeatedly running foo(); -> map is changed but not running "foo" -> assertUnoptimized(foo);

Yes, "foo" is deoptimized, but right after it runs repeatedly before the assertUnoptimized function. The "foo" can be optimized during the repeative execution due to some optimizations modified v8 code. Therefore it's needed at least one execution of "foo" after "map change" before "assertUnoptimized".

deopt "foo" -> Repeatedly running foo(). (foo is changed to OPTIMIZED from UNOPTIMIZED) -> map is changed but not running "foo" -> excute foo(); (foo is UNOPTIMIZED due to map change) -> assertUnoptimized(foo);

I think it does not harm the intent of the test, it is enhanced the test.

--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to