LGTM
https://codereview.chromium.org/1066933005/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1066933005/diff/1/src/parser.cc#newcode2375
src/parser.cc:2375:
scope_->RemoveUnresolved(pattern->AsVariableProxy());
On 2015/04/23 16:29:24, Dmitry Lomov (chromium) wrote:
Here, instead of adding an unresolved proxy and then removing it, I
can
propagate the information that a binding pattern is expected through
the
ExpressionClassifier.
I like this better. I doubt it matters for performance.
https://codereview.chromium.org/1066933005/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/1066933005/diff/1/src/preparser.h#newcode595
src/preparser.h:595: return expression_error_ ==
Scanner::Location::invalid();
return expression_error_.IsValid();
https://codereview.chromium.org/1066933005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
