https://codereview.chromium.org/1108133003/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1108133003/diff/20001/src/heap/heap.cc#newcode4507
src/heap/heap.cc:4507: void Heap::ReduceNewSpaceSize(bool
long_idle_time) {
On 2015/04/28 11:19:09, rmcilroy wrote:
nit - would be clearer as is_long_idle_notification
Done.
https://codereview.chromium.org/1108133003/diff/20001/src/heap/heap.cc#newcode4516
src/heap/heap.cc:4516: bool long_idle_time, double idle_time_in_ms,
size_t size_of_objects,
On 2015/04/28 11:19:08, rmcilroy wrote:
ditto
Done.
https://codereview.chromium.org/1108133003/diff/20001/src/heap/heap.cc#newcode4562
src/heap/heap.cc:4562: bool long_idle_time =
static_cast<size_t>(idle_time_in_ms) >
On 2015/04/28 11:19:08, rmcilroy wrote:
nit - would be clearer as is_long_idle_notification
Done.
https://codereview.chromium.org/1108133003/diff/20001/src/heap/heap.cc#newcode4652
src/heap/heap.cc:4652: ReduceNewSpaceSize(idle_time_in_ms);
On 2015/04/28 11:19:08, rmcilroy wrote:
You are passing idle_time_in_ms to this ReduceNewSpaceSize(bool
long_idle_time)
- are you sure this is what you want to do? Do you want
ReduceNewSpaceSize(idle_time_in_ms >
GCIdleTimeHandler::kMaxFrameRenderingIdleTime)
long_idle_time should be there. thanks, done
https://codereview.chromium.org/1108133003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
