https://codereview.chromium.org/1122973002/diff/1/src/messages.cc
File src/messages.cc (right):
https://codereview.chromium.org/1122973002/diff/1/src/messages.cc#newcode201
src/messages.cc:201: Handle<JSFunction> fun) {
Maybe it's better to use LookupIterator here.
https://codereview.chromium.org/1122973002/diff/1/src/messages.cc#newcode235
src/messages.cc:235: Handle<Object>
lookup(current->SlowReverseLookup(*fun_), isolate);
SlowReverseLookup() does not look into accessor pairs and it does not
handle "multiple matches in the same object" case.
https://codereview.chromium.org/1122973002/diff/1/src/messages.cc#newcode237
src/messages.cc:237: if (!name.is_null()) break;
You probably wanted to return null at this point to avoid "multiple
matches" confusion (in this case please add a comment here).
If not, then why do we need to perform another iteration before exiting
the loop? Why not just break after
name = lookup;
?
https://codereview.chromium.org/1122973002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
