The logic looks good. I think we need to start splitting out some of this
logic
into more testable pieces.
https://codereview.chromium.org/1121573004/diff/1/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/1121573004/diff/1/src/compiler/typer.cc#newcode993
src/compiler/typer.cc:993: int32_t shift_min = rhs->Min();
Would it be possible to pull the integer range logic out to a separate
function so that it can be tested simple integer ranges instead of
requiring the construction of types, etc? That would allow more
exhaustive and more efficient unit testing, and allow us to apply the
rules to machine-left shifts, too.
https://codereview.chromium.org/1121573004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
