On 2015/05/12 08:15:33, jarin wrote:
lgtm with a question.


https://codereview.chromium.org/1128193005/diff/1/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):


https://codereview.chromium.org/1128193005/diff/1/src/compiler/ast-graph-builder.cc#newcode2062
src/compiler/ast-graph-builder.cc:2062:
store_states.ResetBefore(expr->binary_operation()->id());
Can't we make the ResetBefore method private and just record the bailout id here? (And instantiate store_states after the if statement with the recorded
bailout id.)

Done.

https://codereview.chromium.org/1128193005/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to