https://codereview.chromium.org/1138153003/diff/80001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1138153003/diff/80001/src/parser.cc#newcode4029
src/parser.cc:4029: const bool allow_duplicate_parameters =
On 2015/05/13 14:13:05, arv wrote:
Does this handle patterns?
// sloppy
function f(x // ok
function f(x, x // ok
function f(x, x, { // no longer ok
function f(x, x = // no longer ok
I guess it should but it doesn't. In a similar way, duplicate bindings
in patterns are not yet detected, at least not in the preparser. That
will be tricky to do given that a previous attempt to use the
DuplicateFinder for both the parser and the preparser regressed
performance. Perhaps changing the DuplicateFinder to allocate in the
zone instead of via malloc would improve things, though. In any case
it's a problem we will need to solve for arrow functions too:
(x, x) => 10 // error, but currently not caught by the preparser
https://codereview.chromium.org/1138153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
