Landing
https://codereview.chromium.org/1139603005/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1139603005/diff/1/src/parser.cc#newcode3095
src/parser.cc:3095:
Runtime::FunctionForId(Runtime::kThrowIteratorResultNotAnObject),
On 2015/05/19 17:03:48, arv wrote:
Can you use a NewTypeError Expression instead of adding this runtime
function?
Since we already have it I think it is OK but we should probably
remove some of
these later...
I tried that, need to change NewThrowTypeError to accept arbitrary
expressions instead of just literals for arg so too much unrelated
change in this CL. Will do in the follow-up.
https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destructuring.js#newcode394
test/mjsunit/harmony/destructuring.js:394: var [a,b,c] = [1,2,3];
On 2015/05/19 17:03:48, arv wrote:
ws
Done.
https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destructuring.js#newcode535
test/mjsunit/harmony/destructuring.js:535:
On 2015/05/19 17:03:48, arv wrote:
Can you add some recursive tests too?
Done.
https://codereview.chromium.org/1139603005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
