LGTM with nits.
https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):
https://codereview.chromium.org/1140743004/diff/1/src/compiler/js-inlining.cc#newcode298
src/compiler/js-inlining.cc:298: if (mode_ == kBuiltinsInlining &&
!function->shared()->force_inline()) {
nit: Maybe s/kBuiltinsInlining/kRestrictedInlining/ or something like
that?
https://codereview.chromium.org/1140743004/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/1140743004/diff/1/src/hydrogen.cc#newcode7953
src/hydrogen.cc:7953: // Always inline builtins marked for inlining.
nit: Comment is outdated now.
https://codereview.chromium.org/1140743004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
