LGTM with comments, mostly nits.
The ia32 comments apply to all platform ports.
https://codereview.chromium.org/1149903005/diff/40001/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/1149903005/diff/40001/src/code-stubs.h#newcode2194
src/code-stubs.h:2194: explicit
VectorKeyedStoreICTrampolineStub(Isolate* isolate,
nit: "explicit" is unnecessary
https://codereview.chromium.org/1149903005/diff/40001/src/code-stubs.h#newcode2285
src/code-stubs.h:2285: explicit VectorStoreICStub(Isolate* isolate,
const StoreICState& state)
nit: "explicit" is unnecessary
https://codereview.chromium.org/1149903005/diff/40001/src/code-stubs.h#newcode2292
src/code-stubs.h:2292: virtual Code::Kind GetCodeKind() const override {
return Code::STORE_IC; }
nit: the cool kids use only one of "virtual", "override", "final" these
days, specifically the most restrictive that's applicable. (Again
several times below.)
https://codereview.chromium.org/1149903005/diff/40001/src/code-stubs.h#newcode2310
src/code-stubs.h:2310: explicit VectorKeyedStoreICStub(Isolate* isolate,
const StoreICState& state)
nit: "explicit" is unnecessary
https://codereview.chromium.org/1149903005/diff/40001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/1149903005/diff/40001/src/ia32/code-stubs-ia32.cc#newcode4680
src/ia32/code-stubs-ia32.cc:4680: // TODO(mvstanton): Implement.
If you put "UNIMPLEMENTED();" here, you'll get a loud and clear warning
(V8_Fatal) if you ever accidentally try to execute this. That may be
helpful or annoying for the development/debugging workflow you have in
mind, so it's up to you.
https://codereview.chromium.org/1149903005/diff/40001/src/ia32/interface-descriptors-ia32.cc
File src/ia32/interface-descriptors-ia32.cc (right):
https://codereview.chromium.org/1149903005/diff/40001/src/ia32/interface-descriptors-ia32.cc#newcode35
src/ia32/interface-descriptors-ia32.cc:35: const Register
StoreTransitionDescriptor::MapRegister() { return ebx; }
Does this not clash? (Can always punt and fix it when it does.)
https://codereview.chromium.org/1149903005/diff/40001/src/interface-descriptors.h
File src/interface-descriptors.h (right):
https://codereview.chromium.org/1149903005/diff/40001/src/interface-descriptors.h#newcode287
src/interface-descriptors.h:287: class LoadWithVectorDescriptor : public
LoadDescriptor {
Drive-by: maybe put a TODO here to unify these two, now that loads
always use the vector?
https://codereview.chromium.org/1149903005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
