https://codereview.chromium.org/1143623002/diff/140001/src/messages.h
File src/messages.h (right):
https://codereview.chromium.org/1143623002/diff/140001/src/messages.h#newcode230
src/messages.h:230: T(StrongSetProto, "Cannot set internal prototype of
strong object %") \
On 2015/05/22 12:56:44, rossberg wrote:
Nit: stylise error message
Done.
https://codereview.chromium.org/1143623002/diff/140001/test/mjsunit/strong/object-set-prototype.js
File test/mjsunit/strong/object-set-prototype.js (right):
https://codereview.chromium.org/1143623002/diff/140001/test/mjsunit/strong/object-set-prototype.js#newcode40
test/mjsunit/strong/object-set-prototype.js:40: for (let o of
nonStrongObjects) {
On 2015/05/22 12:56:44, rossberg wrote:
nit: nonStrong -> weak
Done.
https://codereview.chromium.org/1143623002/diff/140001/test/mjsunit/strong/object-set-prototype.js#newcode54
test/mjsunit/strong/object-set-prototype.js:54: let setProtoBuiltin =
function(o){Object.setPrototypeOf(o, {})};
On 2015/05/22 12:56:44, rossberg wrote:
Nit: move these out of the loops to share defs
I want to make sure the function was clear of type feedback etc for each
object. Probably paranoia but there's some lowering of builtins and
other stuff that I didn't want to trust.
https://codereview.chromium.org/1143623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
