looking good. just a few nits.
https://codereview.chromium.org/1150593003/diff/200001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1150593003/diff/200001/src/heap/heap.h#newcode718
src/heap/heap.h:718:
Please add comments about what these functions are doing.
https://codereview.chromium.org/1150593003/diff/200001/src/heap/spaces-inl.h
File src/heap/spaces-inl.h (left):
https://codereview.chromium.org/1150593003/diff/200001/src/heap/spaces-inl.h#oldcode377
src/heap/spaces-inl.h:377: (kDoubleUnaligned && (OffsetFrom(obj) &
kDoubleAlignmentMask) != 0));
why did you remove the dcheck?
https://codereview.chromium.org/1150593003/diff/200001/src/heap/spaces-inl.h
File src/heap/spaces-inl.h (right):
https://codereview.chromium.org/1150593003/diff/200001/src/heap/spaces-inl.h#newcode306
src/heap/spaces-inl.h:306: allocation_size = size_in_bytes +
filler_size;
+= filler_size
https://codereview.chromium.org/1150593003/diff/200001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1150593003/diff/200001/test/cctest/test-heap.cc#newcode1785
test/cctest/test-heap.cc:1785:
It would be nice to have test for all the aligned allocation functions
as well. Unfortunately, we do not have that. Would you mind adding some
tests?
https://codereview.chromium.org/1150593003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
