https://codereview.chromium.org/1147503002/diff/100001/src/heap/spaces.cc
File src/heap/spaces.cc (right):
https://codereview.chromium.org/1147503002/diff/100001/src/heap/spaces.cc#newcode659
src/heap/spaces.cc:659: commit_size > CodePageAreaSize()) {
Thank you for spotting this, typo mistake sorry. Too many variables with
the similar names.
https://codereview.chromium.org/1147503002/diff/100001/src/heap/spaces.cc#newcode659
src/heap/spaces.cc:659: commit_size > CodePageAreaSize()) {
On 2015/06/04 10:28:15, Erik Corry wrote:
The commit_size includes the CodePageGuardStartOffset(), but the
CodePageAreaSize does not include it. It looks like you are comparing
two
incomparable things here and I suspect it always takes normal pages
from the
reserved area instead of allocating them individually.
Done.
https://codereview.chromium.org/1147503002/diff/100001/src/mips64/assembler-mips64.h
File src/mips64/assembler-mips64.h (right):
https://codereview.chromium.org/1147503002/diff/100001/src/mips64/assembler-mips64.h#newcode1443
src/mips64/assembler-mips64.h:1443: // If trampoline is emitted,
generated code is becoming large. As this is
On 2015/06/04 10:28:15, Erik Corry wrote:
Is this comment still accurate?
Done.
https://codereview.chromium.org/1147503002/diff/100001/src/mips64/assembler-mips64.h#newcode1443
src/mips64/assembler-mips64.h:1443: // If trampoline is emitted,
generated code is becoming large. As this is
Yes, stale comment from old age.
https://codereview.chromium.org/1147503002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
