Reviewers: tandrii(chromium), Jakob,
Message:
PTAL. The hearbeat method is simply not called when the indicators are
chained.
The output never shows up on the bots and the recipes can sometimes timeout,
like:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug%20-%20novfp3/builds/1329
Maybe the classes should be redesigned (in a follow up) to not impose such
hidden contracts.
Description:
[test] Fix missing heartbeats in test runner.
BUG=
Please review this at https://codereview.chromium.org/1163523008/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -0 lines):
M tools/testrunner/local/progress.py
Index: tools/testrunner/local/progress.py
diff --git a/tools/testrunner/local/progress.py
b/tools/testrunner/local/progress.py
index
19d39f7e6193e4a66857564200a1cb019c3f1d7b..a9519e926d7552418e56aeaf2a7fb764e86bdfbb
100644
--- a/tools/testrunner/local/progress.py
+++ b/tools/testrunner/local/progress.py
@@ -292,6 +292,8 @@ class JUnitTestProgressIndicator(ProgressIndicator):
test.duration,
fail_text)
+ def Heartbeat(self):
+ self.progress_indicator.Heartbeat()
class JsonTestProgressIndicator(ProgressIndicator):
@@ -364,6 +366,9 @@ class JsonTestProgressIndicator(ProgressIndicator):
"duration": test.duration,
})
+ def Heartbeat(self):
+ self.progress_indicator.Heartbeat()
+
PROGRESS_INDICATORS = {
'verbose': VerboseProgressIndicator,
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
