Comments addressed.
https://codereview.chromium.org/1168693002/diff/1/src/compiler/graph-reducer.h
File src/compiler/graph-reducer.h (right):
https://codereview.chromium.org/1168693002/diff/1/src/compiler/graph-reducer.h#newcode126
src/compiler/graph-reducer.h:126: GraphReducer(Graph* graph, Node*
dead_value, Node* dead_control, Zone* zone);
On 2015/06/05 09:42:26, titzer wrote:
Can we move the zone first and then have default values for these
arguments?
Done.
https://codereview.chromium.org/1168693002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/1168693002/diff/1/src/compiler/pipeline.cc#newcode416
src/compiler/pipeline.cc:416: : GraphReducer(js->graph(),
dead_value(js), dead_control(js), zone) {}
On 2015/06/05 09:42:26, titzer wrote:
Why not just inline these private methods?
Done.
https://codereview.chromium.org/1168693002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
