LGTM with comments.
https://codereview.chromium.org/1146963002/diff/160001/src/compiler/js-intrinsic-lowering.cc
File src/compiler/js-intrinsic-lowering.cc (right):
https://codereview.chromium.org/1146963002/diff/160001/src/compiler/js-intrinsic-lowering.cc#newcode464
src/compiler/js-intrinsic-lowering.cc:464: if
(FLAG_turbo_deoptimization) {
This flag no longer exists, we can just perform this step
unconditionally now.
https://codereview.chromium.org/1146963002/diff/160001/src/compiler/js-intrinsic-lowering.cc#newcode479
src/compiler/js-intrinsic-lowering.cc:479: // instruction selection, so
that there is no phase-ordering dependency.
nit: The TODO now no longer applies, correct?
https://codereview.chromium.org/1146963002/diff/160001/src/runtime/runtime-internal.cc
File src/runtime/runtime-internal.cc (right):
https://codereview.chromium.org/1146963002/diff/160001/src/runtime/runtime-internal.cc#newcode424
src/runtime/runtime-internal.cc:424: if (it.frame()->type() !=
StackFrame::STUB) {
nit: Let's use RUNTIME_ASSERT(it.frame()->type() == StackFrame::STUB)
https://codereview.chromium.org/1146963002/diff/160001/src/runtime/runtime-internal.cc#newcode428
src/runtime/runtime-internal.cc:428: if (it.frame()->type() !=
StackFrame::JAVA_SCRIPT) {
nit: Let's use RUNTIME_ASSERT(it.frame()->type() ==
StackFrame::JAVA_SCRIPT)
https://codereview.chromium.org/1146963002/diff/160001/src/runtime/runtime.h
File src/runtime/runtime.h (right):
https://codereview.chromium.org/1146963002/diff/160001/src/runtime/runtime.h#newcode305
src/runtime/runtime.h:305: F(GetCallerJSFunction, 0, 1) \
nit: Can we preserve same order as in the .cc-file, by moving it to the
bottom of the macro?
https://codereview.chromium.org/1146963002/diff/160001/test/mjsunit/get-caller-js-function.js
File test/mjsunit/get-caller-js-function.js (right):
https://codereview.chromium.org/1146963002/diff/160001/test/mjsunit/get-caller-js-function.js#newcode15
test/mjsunit/get-caller-js-function.js:15: }
If we add %OptimizeFunctionOnNextCall(a), could we then get by without
having --always-opt be part of the flags list?
https://codereview.chromium.org/1146963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
