lgtm once comments are addressed:
https://codereview.chromium.org/1135353003/diff/120001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/1135353003/diff/120001/src/heap/mark-compact.cc#newcode2765
src/heap/mark-compact.cc:2765: #if V8_DOUBLE_FIELDS_UNBOXING
I think it is better to use "if (FLAG_unbox_double_fields)" instead of
#if/#endif.
https://codereview.chromium.org/1135353003/diff/120001/src/heap/mark-compact.cc#newcode3180
src/heap/mark-compact.cc:3180: #ifdef V8_DOUBLE_FIELDS_UNBOXING
Same here.
https://codereview.chromium.org/1135353003/diff/120001/src/heap/store-buffer.cc
File src/heap/store-buffer.cc (right):
https://codereview.chromium.org/1135353003/diff/120001/src/heap/store-buffer.cc#newcode501
src/heap/store-buffer.cc:501: #if V8_DOUBLE_FIELDS_UNBOXING
Same here.
https://codereview.chromium.org/1135353003/diff/120001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/1135353003/diff/120001/src/objects-inl.h#newcode1553
src/objects-inl.h:1553: // TODO(jochen): Why do we claim that Code and
Map contain only raw values?
I guess because we never called MayContainRawValues() method for Code
and Map object before, but now we do during the slots filtering. So
probably it makes sense to return kTaggedValues for Code and Map here.
I'm not sure which way is the best: to reorder instance types or to add
more conditions here.
https://codereview.chromium.org/1135353003/diff/120001/src/objects-inl.h#newcode1556
src/objects-inl.h:1556: #if V8_DOUBLE_FIELDS_UNBOXING
I think it is better to use "if (FLAG_unbox_double_fields)" instead of
#if/#endif.
https://codereview.chromium.org/1135353003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
