[v8-dev] [turbofan] Structure AccessBuilder interface a bit. (issue 1178103002 by mstarzinger@chromium.org)

[mstarzinger]

Reviewers: Benedikt Meurer,

Message:
White-space only change.
Description:
[turbofan] Structure AccessBuilder interface a bit.

R=bmeu...@chromium.org

Please review this at https://codereview.chromium.org/1178103002/

Base URL: https://chromium.googlesource.com/v8/v8.git@local_trycatch-enable

Affected files (+32, -23 lines):
  M src/compiler/access-builder.h
  M src/compiler/access-builder.cc


Index: src/compiler/access-builder.cc
diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc
index  
a28075c24c35940d9d42f1e1037a9d962c8a402a..5046fef5935c4b2ea66565491f3d7f272cfb4b44  
100644
--- a/src/compiler/access-builder.cc
+++ b/src/compiler/access-builder.cc
@@ -38,6 +38,13 @@ FieldAccess AccessBuilder::ForJSFunctionContext() {


 // static
+FieldAccess AccessBuilder::ForJSFunctionSharedFunctionInfo() {
+  return {kTaggedBase, JSFunction::kSharedFunctionInfoOffset,  
Handle<Name>(),
+          Type::Any(), kMachAnyTagged};
+}
+
+
+// static
 FieldAccess AccessBuilder::ForJSArrayBufferBackingStore() {
   return {kTaggedBase, JSArrayBuffer::kBackingStoreOffset,  
MaybeHandle<Name>(),
           Type::UntaggedPointer(), kMachPtr};
@@ -129,15 +136,16 @@ FieldAccess AccessBuilder::ForContextSlot(size_t  
index) {


 // static
-FieldAccess AccessBuilder::ForStatsCounter() {
-  return {kUntaggedBase, 0, MaybeHandle<Name>(), Type::Signed32(),  
kMachInt32};
+FieldAccess AccessBuilder::ForPropertyCellValue() {
+  return {kTaggedBase, PropertyCell::kValueOffset, Handle<Name>(),  
Type::Any(),
+          kMachAnyTagged};
 }


 // static
-FieldAccess AccessBuilder::ForPropertyCellValue() {
-  return {kTaggedBase, PropertyCell::kValueOffset, Handle<Name>(),  
Type::Any(),
-          kMachAnyTagged};
+FieldAccess AccessBuilder::ForSharedFunctionInfoTypeFeedbackVector() {
+  return {kTaggedBase, SharedFunctionInfo::kFeedbackVectorOffset,
+          Handle<Name>(), Type::Any(), kMachAnyTagged};
 }


@@ -192,16 +200,8 @@ ElementAccess  
AccessBuilder::ForSeqStringChar(String::Encoding encoding) {


 // static
-FieldAccess AccessBuilder::ForJSFunctionSharedFunctionInfo() {
-  return {kTaggedBase, JSFunction::kSharedFunctionInfoOffset,  
Handle<Name>(),
-          Type::Any(), kMachAnyTagged};
-}
-
-
-// static
-FieldAccess AccessBuilder::ForSharedFunctionInfoTypeFeedbackVector() {
-  return {kTaggedBase, SharedFunctionInfo::kFeedbackVectorOffset,
-          Handle<Name>(), Type::Any(), kMachAnyTagged};
+FieldAccess AccessBuilder::ForStatsCounter() {
+  return {kUntaggedBase, 0, MaybeHandle<Name>(), Type::Signed32(),  
kMachInt32};
 }


Index: src/compiler/access-builder.h
diff --git a/src/compiler/access-builder.h b/src/compiler/access-builder.h
index  
e4d1332771d8fa4306afb3f5599be74864a794ff..240ffdcb5dac59d11998b0bf7cf0c0b386f61197  
100644
--- a/src/compiler/access-builder.h
+++ b/src/compiler/access-builder.h
@@ -16,6 +16,9 @@ namespace compiler {
 // parameters to simplified load/store operators.
 class AccessBuilder final : public AllStatic {
  public:
+  //  
===========================================================================
+  // Access to heap object fields and elements (based on tagged pointer).
+
   // Provides access to HeapObject::map() field.
   static FieldAccess ForMap();

@@ -28,6 +31,9 @@ class AccessBuilder final : public AllStatic {
   // Provides access to JSFunction::context() field.
   static FieldAccess ForJSFunctionContext();

+  // Provides access to JSFunction::shared() field.
+  static FieldAccess ForJSFunctionSharedFunctionInfo();
+
   // Provides access to JSArrayBuffer::backing_store() field.
   static FieldAccess ForJSArrayBufferBackingStore();

@@ -64,12 +70,12 @@ class AccessBuilder final : public AllStatic {
   // Provides access Context slots.
   static FieldAccess ForContextSlot(size_t index);

-  // Provides access to the backing store of a StatsCounter.
-  static FieldAccess ForStatsCounter();
-
   // Provides access to PropertyCell::value() field.
   static FieldAccess ForPropertyCellValue();

+  // Provides access to SharedFunctionInfo::feedback_vector() field.
+  static FieldAccess ForSharedFunctionInfoTypeFeedbackVector();
+
   // Provides access to FixedArray elements.
   static ElementAccess ForFixedArrayElement();

@@ -77,14 +83,17 @@ class AccessBuilder final : public AllStatic {
   static ElementAccess ForTypedArrayElement(ExternalArrayType type,
                                             bool is_external);

-  // Provides access to the charaters of sequential strings.
+  // Provides access to the characters of sequential strings.
   static ElementAccess ForSeqStringChar(String::Encoding encoding);

-  // Provides access to the SharedFunctionInfo in a JSFunction.
-  static FieldAccess ForJSFunctionSharedFunctionInfo();
+  //  
===========================================================================
+  // Access to global per-isolate variables (based on external reference).

-  // Provides access to the TypeFeedbackVector in SharedFunctionInfo.
-  static FieldAccess ForSharedFunctionInfoTypeFeedbackVector();
+  // Provides access to the backing store of a StatsCounter.
+  static FieldAccess ForStatsCounter();
+
+  //  
===========================================================================
+  // Access to activation records on the stack (based on frame pointer).

   // Provides access to the next frame pointer in a stack frame.
   static FieldAccess ForFrameCallerFramePtr();


--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.