comments addressed, landing
https://codereview.chromium.org/1167393005/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1167393005/diff/20001/src/parser.cc#newcode1187
src/parser.cc:1187: BlockState block_state(&scope_, scope);
On 2015/06/15 15:21:59, arv wrote:
Why was this block state added? It does not seem like it is needed for
parsing.
Ah, this is a tricky bit. Parsing patterns as variable reference
expressions creates NewUnresolved references in current scope. This
BlockState makes arrow function scope the current scope - otherwise we
will create NewUnresolved in outer scope - this is logically wrong, but
not only - in case of lazy parsing the outer scope is immutable, so we
assert.
https://codereview.chromium.org/1167393005/diff/20001/src/parser.cc#newcode3813
src/parser.cc:3813: // TODO(wingo): Support rest parameters.
On 2015/06/15 15:21:59, arv wrote:
Andy implemented this last week.
Removed.
https://codereview.chromium.org/1167393005/diff/20001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/1167393005/diff/20001/test/cctest/test-parsing.cc#newcode6617
test/cctest/test-parsing.cc:6617: "{a : a}",
On 2015/06/15 15:21:59, arv wrote:
Isn't this case already covered on line 6405?
Removed.
https://codereview.chromium.org/1167393005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
