Reviewers: Michael Achenbach,
Message:
Let's try this again. The fix for the make generator is in
(https://codereview.chromium.org/1187073008).
Last time, we had several funny build errors within the first 24h, so I'd
take
that as my probabtion period for this CL.. :-)
Description:
Re-Re-land: Enable external startup by default on Linux.
crrev.com/1177163002 should have fixed the issues that broke this last time.
Notes:
- The current functionality is meant to stay. If you prefer the old way,
just set v8_use_external_startup_data=0.
- You might notice this if you call d8 via PATH. Either explicitly tell d8
where your external snapshot/built-ins are, or change the build options
as above.
- This follows Chromium practice, that mostly uses this feature these days.
- Other platforms to follow later.
BUG=
Please review this at https://codereview.chromium.org/1189563004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -0 lines):
M build/standalone.gypi
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index
7562112443d2252fadf46c9fbdab85b6bdf5db2d..f8b5674c242fe5b83efa1bbb34cfb191b2e05e41
100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -201,6 +201,11 @@
# the C++ standard library is used.
'use_custom_libcxx%': 1,
}],
+ ['OS=="linux" and v8_target_arch==host_arch', {
+ # Gradually roll out v8_use_external_startup_data.
+ # Should eventually be default enabled on all platforms.
+ 'v8_use_external_startup_data%': 1,
+ }],
],
# Default ARM variable settings.
'arm_version%': 'default',
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
