https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode489
src/compiler.cc:489: // TODO(turbofan): Currently everything is done in
the first phase.
nit: TODO no longer applies, let's drop it.
https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode490
src/compiler.cc:490: if (pipeline_) {
Should we move this down a few lines so that it is covered by the below
timer?
https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode512
src/compiler.cc:512: // TODO(turbofan): Currently everything is done in
the first phase.
nit: TODO no longer applies, let's drop it.
https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode514
src/compiler.cc:514: Handle<Code> optimized_code =
pipeline_->CreateCode();
This can now be intergrated into the code below, so that the call to
RecordOptimizationStats at the bottom is used. Also having this covered
by the three Disallow scopes below might be good.
https://codereview.chromium.org/1179393008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
