LGTM!
http://codereview.chromium.org/546089/diff/1/3 File src/handles.cc (right): http://codereview.chromium.org/546089/diff/1/3#newcode685 src/handles.cc:685: LOG(FunctionInfoEvent(*function)); How about FunctionCreateEvent? The actual JS function object is created here. http://codereview.chromium.org/546089/diff/1/5 File src/log.h (right): http://codereview.chromium.org/546089/diff/1/5#newcode118 src/log.h:118: V(CODE_DELETE_EVENT, "code-delete", "cd") \ Do we need a function delete event? http://codereview.chromium.org/546089/diff/1/5#newcode119 src/log.h:119: V(FUNCTION_INFO_EVENT, "function-info", "fi") \ INFO -> CREATION, info -> creation? http://codereview.chromium.org/546089/diff/1/6 File src/mark-compact.cc (right): http://codereview.chromium.org/546089/diff/1/6#newcode1954 src/mark-compact.cc:1954: LOG(CodeMoveEvent(old_addr, new_addr)); Should we have a FunctionMoveEvent? Or just a generic ObjectMoveEvent (perhaps with a type)? Using the CodeMoveEvent for a JSFunction object seems confusing. http://codereview.chromium.org/546089/diff/1/20 File tools/tickprocessor.js (right): http://codereview.chromium.org/546089/diff/1/20#newcode286 tools/tickprocessor.js:286: this.profile_.addCodeAlias(functionAddr, codeAddr); Are these aliases ever removed? http://codereview.chromium.org/546089
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
