On 2015/06/24 14:36:42, Michael Starzinger wrote:
https://codereview.chromium.org/1205783003/diff/1/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/1205783003/diff/1/src/factory.cc#newcode1390
src/factory.cc:1390: if (cached.literals == nullptr && !info->bound()) {
On 2015/06/24 14:01:53, jarin wrote:
> Any reason why not to say something like
>
> ...
> } else if (!info->bound()) {
> // Maybe if you like, DCHECK(cached.literals == nullptr);
> ...
> }
I would like to get to an interface where the result of the lookup can be
contain a code object but no literals array (i.e. { code=<some-code>,
literals=nullptr}) to indicate that the code object can be used, but a new
literals array needs to be allocated.
This would happen when we have optimized code that can be shared across
native-contexts. The code can be shared, but the literals array cannot,
because
the boilerplate objects always are specific to one native-context.
WDYT?
Makes sense.
https://codereview.chromium.org/1205783003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
