LGTM with a nit.
https://codereview.chromium.org/1218443002/diff/1/src/compiler/common-operator-reducer.cc
File src/compiler/common-operator-reducer.cc (right):
https://codereview.chromium.org/1218443002/diff/1/src/compiler/common-operator-reducer.cc#newcode102
src/compiler/common-operator-reducer.cc:102: // Negative the hint for
{branch}.
Why do we need the switch at all? Isn't the simple one-liner
node->set_op(common()->Branch(NegateBranch(BranchHintOf(node->op()));
enough for all cases? Then comment would be superfluous, BTW. If it's a
nano-optimization, please add a comment why it's necessary.
https://codereview.chromium.org/1218443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
