Reviewers: adamk,
Message:
Is there a better approach?
Should this patch remove the --harmony-arrays flag or leave it in as a
vestige
that doesn't do anything?
Description:
Include Harmony Array/TypedArray methods unconditionally
Conditionally including Array and TypedArray methods seems to cause
a slowdown in V8 context creation, possibly due to the new code added.
This patch makes the --harmony-array flag basically inoperative by
always keeping it on. It should be easy to revert this patch to
make the flag configurable.
BUG=chromium:504629
[email protected]
LOG=Y
Please review this at https://codereview.chromium.org/1215863003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+5, -6 lines):
M BUILD.gn
M src/bootstrapper.cc
M tools/gyp/v8.gyp
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
c97ad62c43614c322bcb25c27cedfebbe51f0ef4..e1b3ab9164e61e4771f1c21a7cb94a12f023f48c
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -231,6 +231,8 @@ action("js2c") {
"src/mirror-debugger.js",
"src/liveedit-debugger.js",
"src/templates.js",
+ "src/harmony-array.js",
+ "src/harmony-typedarray.js",
]
outputs = [
@@ -270,9 +272,7 @@ action("js2c_experimental") {
"src/proxy.js",
"src/generator.js",
"src/harmony-atomics.js",
- "src/harmony-array.js",
"src/harmony-array-includes.js",
- "src/harmony-typedarray.js",
"src/harmony-tostring.js",
"src/harmony-regexp.js",
"src/harmony-reflect.js",
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index
72fbf1282e5b9716b5cbb4309551fcc2a246ec97..b04bdfbb43dc7e07204d2f38f8b1b34db66fe327
100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2468,8 +2468,7 @@ bool Genesis::InstallNatives() {
bool Genesis::InstallExperimentalNatives() {
- static const char* harmony_arrays_natives[] = {
- "native harmony-array.js", "native harmony-typedarray.js", nullptr};
+ static const char* harmony_arrays_natives[] = {nullptr};
static const char* harmony_array_includes_natives[] = {
"native harmony-array-includes.js", nullptr};
static const char* harmony_proxies_natives[] = {"native proxy.js",
nullptr};
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index
9be673f8da3bf61c48e534065c8463bbdc131611..8f4f20d67692504afcfedd8698970ab56d525855
100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -1766,6 +1766,8 @@
'../../src/mirror-debugger.js',
'../../src/liveedit-debugger.js',
'../../src/templates.js',
+ '../../src/harmony-array.js',
+ '../../src/harmony-typedarray.js',
],
'experimental_library_files': [
'../../src/macros.py',
@@ -1773,10 +1775,8 @@
'../../src/proxy.js',
'../../src/generator.js',
'../../src/harmony-atomics.js',
- '../../src/harmony-array.js',
'../../src/harmony-array-includes.js',
'../../src/harmony-tostring.js',
- '../../src/harmony-typedarray.js',
'../../src/harmony-regexp.js',
'../../src/harmony-reflect.js',
'../../src/harmony-spread.js',
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
