I looked at parts of this. I worry that there are too many different stubs and that we will get a stub number explosion. Can we consolidate some of them and still get most of the performance benefit?
http://codereview.chromium.org/551093/diff/1/3 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/551093/diff/1/3#newcode744 src/ia32/codegen-ia32.cc:744: enum ArgsLocation { I would prefer ArgLocation. http://codereview.chromium.org/551093/diff/1/3#newcode760 src/ia32/codegen-ia32.cc:760: // Returns operands as floating point numbers on FPU stack. No capital letter after a comma. http://codereview.chromium.org/551093/diff/1/3#newcode789 src/ia32/codegen-ia32.cc:789: // Accepts operands on stack or in eax,ebx. Space after comma. http://codereview.chromium.org/551093/diff/1/3#newcode799 src/ia32/codegen-ia32.cc:799: case BINARY_OP_STUB_GENERIC: return "Universal"; break; You don't need a break after a return. http://codereview.chromium.org/551093/diff/1/3#newcode1398 src/ia32/codegen-ia32.cc:1398: __ add(answer.reg(), Operand(right->reg())); I think the comment should go back. http://codereview.chromium.org/551093/diff/1/3#newcode7265 src/ia32/codegen-ia32.cc:7265: ASSERT(kSmiTag == 0); // adjust zero check if not the case adjust -> Adjust case -> case. http://codereview.chromium.org/551093 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
