LGTM (ARM + ARM64)
Thanks!
I think we should (later) investigate the saving of x30 (lr) for ARM64 but
you've covered this with a TODO and the behaviour is unchanged.
(Push/PopCalleeSavedRegisters also preserve lr, though they probably
shouldn't.)
https://codereview.chromium.org/1191513003/diff/120001/src/compiler/arm64/code-generator-arm64.cc
File src/compiler/arm64/code-generator-arm64.cc (right):
https://codereview.chromium.org/1191513003/diff/120001/src/compiler/arm64/code-generator-arm64.cc#newcode1108
src/compiler/arm64/code-generator-arm64.cc:1108: //
CPURegList::GetCalleeSaved(): x30 is missing.
x30 (lr) is caller-saved in the procedure-call standard, so we don't
really need to save it for the PCS alone. (ARM doesn't save its LR so I
presume that TF doesn't have a special need for it.) However, we do need
to save an even number of X registers here so perhaps we save it to bump
us up to an even number.
https://codereview.chromium.org/1191513003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
