Looks interesting. Couple of questions: 0) Could you send it to Vitaly to get his review? 1) Will this generate AFTER_COMPILE event? 2) Can we act as Eclipse for the cases when new script does not compile? (replace body with "throw 'Syntax error: ...';" )
http://codereview.chromium.org/546125/diff/4001/4002 File src/debug-delay.js (right): http://codereview.chromium.org/546125/diff/4001/4002#newcode748 src/debug-delay.js:748: Debug.change_script_live = function(script, pos, old_len, new_str) { I'd call it something like 'patch_script'. Also comment on what it does would be nice. http://codereview.chromium.org/546125/diff/4001/4003 File src/runtime.cc (right): http://codereview.chromium.org/546125/diff/4001/4003#newcode7936 src/runtime.cc:7936: static Object* Runtime_GetOverlappingFunctionInfos(Arguments args) { It is strange that mutator has a Get* name. Also, debugger functions are generally called Runtime_Debug*. http://codereview.chromium.org/546125 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
