This patchset also removes one of the runtime checks for compare.
https://codereview.chromium.org/1216463003/diff/140001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/1216463003/diff/140001/src/compiler/ast-graph-builder.cc#newcode2684
src/compiler/ast-graph-builder.cc:2684: // This should never deoptimize
in sloppy mode because we have converted to
On 2015/06/30 12:53:52, rossberg wrote:
s/sloppy/weak/ ?
reworded
https://codereview.chromium.org/1216463003/diff/140001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/1216463003/diff/140001/src/hydrogen.cc#newcode10326
src/hydrogen.cc:10326: if (!is_strong(function_language_mode())) {
On 2015/06/30 12:53:52, rossberg wrote:
Hm, why no recording in strong mode? Can you add a comment?
Urk, this was something I added while misunderstanding the
representation change phase. I should have removed it.
https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions-constants.js
File test/mjsunit/strong/implicit-conversions-constants.js (right):
https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions-constants.js#newcode12
test/mjsunit/strong/implicit-conversions-constants.js:12:
function(x){return 1 + true;},
On 2015/06/30 12:53:52, rossberg wrote:
CAn't you generate these functions using eval?
Since this is specifically testing a folding that the optimizing
compiler does, I wasn't sure if it would trigger with eval'd code.
https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions-count.js
File test/mjsunit/strong/implicit-conversions-count.js (right):
https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions-count.js#newcode140
test/mjsunit/strong/implicit-conversions-count.js:140: //Check prior
input of Smi works
On 2015/06/30 12:53:52, rossberg wrote:
Nit: WS
Done.
https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions-count.js#newcode155
test/mjsunit/strong/implicit-conversions-count.js:155: //Check prior
input of Number works
On 2015/06/30 12:53:52, rossberg wrote:
Nit: WS
Done.
https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions.js
File test/mjsunit/strong/implicit-conversions.js (left):
https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions.js#oldcode64
test/mjsunit/strong/implicit-conversions.js:64: "0.79",
On 2015/06/30 12:53:52, rossberg wrote:
Why did you remove these cases?
The runtime of this test was beginning to get excessive, and the cases I
removed weren't exercising any different paths in the IC/stub code. I
wrote this test before I knew how ICs worked so I didn't choose the most
sensible values.
https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions.js
File test/mjsunit/strong/implicit-conversions.js (right):
https://codereview.chromium.org/1216463003/diff/140001/test/mjsunit/strong/implicit-conversions.js#newcode345
test/mjsunit/strong/implicit-conversions.js:345: print(func);
On 2015/06/30 12:53:52, rossberg wrote:
Stray debug output?
Done.
https://codereview.chromium.org/1216463003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
