Reviewers: Hannes Payer,
Description:
Version 4.4.63.12 (cherry-pick)
Merged e60ce8d1468d781b2b4aec19d76090299d196ae8
Register array buffer right after writing it into the object
BUG=chromium:504875
LOG=N
TBR=hpa...@chromium.org
Please review this at https://codereview.chromium.org/1218783007/
Base URL: https://chromium.googlesource.com/v8/v8.git@4.4
Affected files (+6, -6 lines):
M include/v8-version.h
M src/runtime/runtime-typedarray.cc
Index: include/v8-version.h
diff --git a/include/v8-version.h b/include/v8-version.h
index
e2c07ba803faecbd392778db8a087feb41c7c8fc..2f2ea5533387d00908c92d7b60a5a8d084ce67ec
100644
--- a/include/v8-version.h
+++ b/include/v8-version.h
@@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 4
#define V8_MINOR_VERSION 4
#define V8_BUILD_NUMBER 63
-#define V8_PATCH_LEVEL 11
+#define V8_PATCH_LEVEL 12
// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Index: src/runtime/runtime-typedarray.cc
diff --git a/src/runtime/runtime-typedarray.cc
b/src/runtime/runtime-typedarray.cc
index
10aba0cc42468614e48757e609b8788049171a65..fed6795509c83493e43f8ec5146a2f69cb27914b
100644
--- a/src/runtime/runtime-typedarray.cc
+++ b/src/runtime/runtime-typedarray.cc
@@ -27,15 +27,15 @@ void Runtime::SetupArrayBuffer(Isolate* isolate,
array_buffer->set_is_external(is_external);
array_buffer->set_is_neuterable(true);
- Handle<Object> byte_length =
- isolate->factory()->NewNumberFromSize(allocated_length);
- CHECK(byte_length->IsSmi() || byte_length->IsHeapNumber());
- array_buffer->set_byte_length(*byte_length);
-
if (data && !is_external) {
isolate->heap()->RegisterNewArrayBuffer(
isolate->heap()->InNewSpace(*array_buffer), data,
allocated_length);
}
+
+ Handle<Object> byte_length =
+ isolate->factory()->NewNumberFromSize(allocated_length);
+ CHECK(byte_length->IsSmi() || byte_length->IsHeapNumber());
+ array_buffer->set_byte_length(*byte_length);
}
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
