Reviewers: Hannes Payer,
Message:
Please advise whether this flag is still needed.
Description:
Remove deprecated --incremental-code-compaction flag.
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/1216153004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -6 lines):
M src/flag-definitions.h
M src/heap/mark-compact.cc
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
81b258b66ac7861bce2102a9e68948ccebf9f036..8fb2b545c74a8c305d5b24e918a6bb8e43b72439
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -672,10 +672,7 @@ DEFINE_BOOL(native_code_counters, false,
DEFINE_BOOL(always_compact, false, "Perform compaction on every full GC")
DEFINE_BOOL(never_compact, false,
"Never perform compaction on full GC - testing only")
-DEFINE_BOOL(compact_code_space, true,
- "Compact code space on full non-incremental collections")
-DEFINE_BOOL(incremental_code_compaction, true,
- "Compact code space on full incremental collections")
+DEFINE_BOOL(compact_code_space, true, "Compact code space on full
collections")
DEFINE_BOOL(cleanup_code_caches_at_gc, true,
"Flush inline caches prior to mark compact collection and "
"flush code caches in maps during mark compact cycle.")
Index: src/heap/mark-compact.cc
diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc
index
e4f2040c6f1d3362b9b127b2e2f01002d12e97c3..dee8d9319fc03c5c5cbae6e008cdd1efb3d8d835
100644
--- a/src/heap/mark-compact.cc
+++ b/src/heap/mark-compact.cc
@@ -260,8 +260,7 @@ bool
MarkCompactCollector::StartCompaction(CompactionMode mode) {
CollectEvacuationCandidates(heap()->old_space());
- if (FLAG_compact_code_space && (mode == NON_INCREMENTAL_COMPACTION ||
- FLAG_incremental_code_compaction)) {
+ if (FLAG_compact_code_space) {
CollectEvacuationCandidates(heap()->code_space());
} else if (FLAG_trace_fragmentation) {
TraceFragmentation(heap()->code_space());
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
