On 2010/01/25 13:01:40, Søren Gjesse wrote:
LGTM with a style comment:
In the V8 code base we always have explicit check against NULL, so
while (HeapObject* obj = it.next()) {
needs to be
while ((HeapObject* obj = it.next()) != NULL) {
As the while with != NULL check requires hoisting the declaration of obj
out of
the while scope using a for loop
for (HeapObject* obj = it.next(); obj != NULL; obj = it.next()) {
is probably the best choice.
http://codereview.chromium.org/555072
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
