looks good, few nits:
https://codereview.chromium.org/1222093007/diff/1/src/assembler.cc
File src/assembler.cc (right):
https://codereview.chromium.org/1222093007/diff/1/src/assembler.cc#newcode517
src/assembler.cc:517: if (RelocInfo::IsDebugBreakSlot(rmode)) {
Let's make it into a method with descriptive name e.g.
WriteDebugBreakData()
https://codereview.chromium.org/1222093007/diff/1/src/assembler.cc#newcode719
src/assembler.cc:719: AdvanceReadInt();
The old name was more discriptive: AdvanceReadPoolData. Can we restore
it?
https://codereview.chromium.org/1222093007/diff/1/src/assembler.cc#newcode727
src/assembler.cc:727: if (RelocInfo::IsDebugBreakSlot(rmode)) {
Let's extract this into a separate function "AdvanceReadDebugSlotData"
https://codereview.chromium.org/1222093007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
