Thanks. I'll add more tests and investigate the error reporting.
https://codereview.chromium.org/1234433002/diff/20001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1234433002/diff/20001/src/parser.cc#newcode2230
src/parser.cc:2230: Declare(declaration, DeclarationDescriptor::NORMAL,
true, &var_ok);
I was wondering if this actually reports an error. I'll need to look
into it and add test etc.
https://codereview.chromium.org/1234433002/diff/20001/test/mjsunit/harmony/block-function-sloppy.js
File test/mjsunit/harmony/block-function-sloppy.js (right):
https://codereview.chromium.org/1234433002/diff/20001/test/mjsunit/harmony/block-function-sloppy.js#newcode30
test/mjsunit/harmony/block-function-sloppy.js:30: (function
TestNoInitIf() {
On 2015/07/10 12:18:27, rossberg wrote:
You have all these tests for the NoInit case, but none for a
successful
control-dependent case. Can you add some, too?
Doh! I will add.
https://codereview.chromium.org/1234433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
