lgtm
https://codereview.chromium.org/1226143003/diff/60001/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/1226143003/diff/60001/src/d8.cc#newcode1693
src/d8.cc:1693: if (base::NoBarrier_CompareAndSwap(&join_called_, false,
true) == false) {
It looks like join_called_ is only used for debugging. Could we perhaps
just DCHECK here? (Hmm, the compiler might complain about join_called_
not being used.)
https://codereview.chromium.org/1226143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
