https://codereview.chromium.org/1240463002/diff/1/src/scopes.cc
File src/scopes.cc (right):
https://codereview.chromium.org/1240463002/diff/1/src/scopes.cc#newcode1369
src/scopes.cc:1369:
outer_scope()->DeclarationScope()->AllocateStackSlot(var);
On 2015/07/13 16:00:51, caitp wrote:
Won't DeclarationScope() get outer_scope() on its own if
is_block_scope() is
true? It looks like it does
Not if it is a block scope that is a declaration scope, which is exactly
what this CL introduces. Without this, you'd run into an infinite loop.
https://codereview.chromium.org/1240463002/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1240463002/diff/1/test/mjsunit/harmony/destructuring.js#newcode761
test/mjsunit/harmony/destructuring.js:761: // TODO(rossberg): Check for
variable collision.
On 2015/07/13 19:27:31, adamk wrote:
Do you mean to take care of this in this patch or a followup?
I leave that for a future CL. Leaving out this check for now does not
break anything, other than allowing a few more programs.
https://codereview.chromium.org/1240463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
