Reviewers: Igor Sheludko,
Message:
ptal. I'll only land if the bots cycle green.
SetAccessor is internal, and could be done with "defineProperty" which
reconfigures rather than setting, so it would ignore readonly...
Description:
Allow setting accessor infos over read-only but configurable properties.
BUG=
Please review this at https://codereview.chromium.org/1228373004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
d60fb7c1aaa356611a6d8d8f4115a2cfeb16dbef..0aa2da678656aac9189f2fb5863de0a4ba718a17
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -6346,7 +6346,7 @@ MaybeHandle<Object>
JSObject::SetAccessor(Handle<JSObject> object,
// ES5 forbids turning a property into an accessor if it's not
// configurable. See 8.6.1 (Table 5).
- if (it.IsFound() && (it.IsReadOnly() || !it.IsConfigurable())) {
+ if (it.IsFound() && !it.IsConfigurable()) {
return it.factory()->undefined_value();
}
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
