Comment #9 on issue 4279 by bugdro...@chromium.org: Check failed: 0 ==
result in v8::base::DestroyNativeHandle
https://code.google.com/p/v8/issues/detail?id=4279#c9
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/4073657ec828617beaeae6f8088449ca3fd6f6f7
commit 4073657ec828617beaeae6f8088449ca3fd6f6f7
Author: binji <bi...@chromium.org>
Date: Tue Jul 14 23:04:18 2015
Reland of d8 workers: make sure Shell::Quit is only called once (patchset
#1 id:1 of https://codereview.chromium.org/1235083004/)
Reason for revert:
Looks like the failure is unrelated to my change (still fails after the
revert). See
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/856/steps/webkit_unit_tests/logs/stdio
Original issue's description:
Revert of d8 workers: make sure Shell::Quit is only called once (patchset
#5 id:80001 of https://codereview.chromium.org/1230403003/)
Reason for revert:
Breaks webkit_unit_tests. See
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/853/steps/webkit_unit_tests/logs/stdio
Original issue's description:
> d8 workers: make sure Shell::Quit is only called once
>
> When running with isolates, Quit can be called simultaneously by two
threads.
> If this happens, then both threads try to clean up the Workers, which
could
> crash.
>
> BUG=v8:4279
> R=ja...@chromium.org
> R=machenb...@chromium.org
> LOG=n
>
> Committed: https://crrev.com/76184292b392d107609f21662a949b58bb1e258c
> Cr-Commit-Position: refs/heads/master@{#29654}
TBR=ja...@chromium.org,machenb...@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4279
Committed: https://crrev.com/6b2c6eb75678747afca59b4a78ace597e218145d
Cr-Commit-Position: refs/heads/master@{#29656}
TBR=ja...@chromium.org,machenb...@chromium.org,ad...@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4279
Review URL: https://codereview.chromium.org/1224203004
Cr-Commit-Position: refs/heads/master@{#29663}
[modify] http://crrev.com/4073657ec828617beaeae6f8088449ca3fd6f6f7/src/d8.cc
[modify] http://crrev.com/4073657ec828617beaeae6f8088449ca3fd6f6f7/src/d8.h
[modify]
http://crrev.com/4073657ec828617beaeae6f8088449ca3fd6f6f7/test/mjsunit/mjsunit.status
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
