On 2015/07/22 08:09:01, jbramley wrote:
On 2015/07/22 08:07:41, Michael Starzinger wrote:
>
https://codereview.chromium.org/1241223003/diff/1/src/arm64/code-stubs-arm64.cc
> File src/arm64/code-stubs-arm64.cc (right):
>
>
https://codereview.chromium.org/1241223003/diff/1/src/arm64/code-stubs-arm64.cc#newcode2758
> src/arm64/code-stubs-arm64.cc:2758: __ Push(argc, function,
feedback_vector,
> index, orig_construct);
> On 2015/07/22 07:51:36, jbramley wrote:
> > Why not pass orig_construct=NoReg for the !is_super case? That way you
don't
> > need the complexity in this function (or in GenerateRecordCallTarget).
> >
> > I don't think the same will work for ARM, but it's a separate Push
there
> anyway.
>
> The way the 8-register push is implemented, it assumes that 5 registers
are
> always valid and only treats the last 3 registers as "var-args" that
could
be
> invalid.
Ah, fair enough. I think I'd like to fix that, but perhaps not for this
patch.
Acknowledged. SGTM.
https://codereview.chromium.org/1241223003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
