Ouch, my eyes! lgtm.
https://codereview.chromium.org/1248483007/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1248483007/diff/20001/src/heap/heap.cc#newcode4012
src/heap/heap.cc:4012: kHeapObjectTag),
Can't you say
ExternalReference::fixed_typed_array_base_data_offset().address() here?
https://codereview.chromium.org/1248483007/diff/20001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/1248483007/diff/20001/src/ia32/lithium-codegen-ia32.cc#newcode4097
src/ia32/lithium-codegen-ia32.cc:4097: Comment(";;; LOL Store");
What is LOL?
https://codereview.chromium.org/1248483007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
