Looks good, just a nit.
https://codereview.chromium.org/1240093005/diff/70001/src/dateparser.cc
File src/dateparser.cc (right):
https://codereview.chromium.org/1240093005/diff/70001/src/dateparser.cc#newcode84
src/dateparser.cc:84: if (hour == 24 && minute == 0 && second == 0 &&
millisecond == 0) {
Invert to (hour != 24 || minute != 0 || second != 0 || millisecond != 0)
and drop the else branch.
https://codereview.chromium.org/1240093005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
