Yay! But I'd like to harden this a bit if possible. Field sharing is dangerous
business.

https://codereview.chromium.org/1252473002/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1252473002/diff/1/src/objects-inl.h#newcode5479
src/objects-inl.h:5479: bool has_debug_info = !IsApiFunction() &&
debug_info()->IsStruct();
I can haz DCHECK(!IsApiFunction()) inside debug_info()? That probably
requires adding checks at other call sites, but would let me sleep
better.

https://codereview.chromium.org/1252473002/

--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to